Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create valgrind.adoc #352

Closed
wants to merge 4 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
34 changes: 34 additions & 0 deletions website/content/en/status/report-2024-01-2024-03/valgrind.adoc
@@ -0,0 +1,34 @@
=== Valgrind: port to arm64 on its way

Links: +
link:https://www.valgrind.org/[Valgrind Home Page] URL: link:https://www.valgrind.org/[] +
link:https://www.valgrind.org/docs/manual/dist.news.html[Valgrind News] URL: link:https://www.valgrind.org/docs/manual/dist.news.html[]
link:https://github.com/paulfloyd/freebsdarm64_valgrind[arm64 port] URL: link:https://github.com/paulfloyd/freebsdarm64_valgrind[]

Contact: Paul Floyd <pjfloyd@wanadoo.fr>

The major news, as per the title, is that a port to FreeBSD arm64 (or aarch64) is now ready.
The next steps are to get it reviewed and pushed upstream.

Valgrind 3.23 due out at the end of April 2024 and package:devel/valgrind[] will be updated shortly after that.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind that I am not a native English speaker, but this does not sound right to me. Maybe

Suggested change
Valgrind 3.23 due out at the end of April 2024 and package:devel/valgrind[] will be updated shortly after that.
Valgrind 3.23 is due out at the end of April 2024 and package:devel/valgrind[] will be updated shortly after that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK


package:devel/valgrind-devel[] will get an update as soon as I've pushed the changes for arm64.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid contractions.

Suggested change
package:devel/valgrind-devel[] will get an update as soon as I've pushed the changes for arm64.
package:devel/valgrind-devel[] will get an update as soon as I have pushed the changes for arm64.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK as well


`--track-fds=yes` now checks for and warns about attempts to close a file decriptor more than once.
Handling of closefrom has been improved to use this feature.

There are some important fixes for FreeBSD 15, in particular handling the new `libsys`.

Here is a list of smaller bugfixes:

* Support for FreeBSD 13.3 has been added.
* Added a redirect for `reallocarray`.
* Several fixes for `aio*` functions.
* Added a redirect for `memccpy`.
* There is a fix for `_umtx_op OP_ROBUST_LISTS`.
* Added redirs for C23 `free_sized` and `free_aligned_sized`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added redirs for C23 `free_sized` and `free_aligned_sized`.
* Added redirects for C23 `free_sized` and `free_aligned_sized`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

* Correctly propagate the ELF stack protection flags to the guest stack that Valgrind synthesizes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Correctly propagate the ELF stack protection flags to the guest stack that Valgrind synthesizes.
* Correctly propagated the ELF stack protection flags to the guest stack that Valgrind synthesizes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it should be present continuous, this is something that gets done at every startup. Previously this was hard coded and did not respect the guest stack protection flags.

* Fixes for `--sanity-level-3` and above (only used for Valgrind self-testing at runtime).
* Several fixes to checking done for `semctl`.
* Fixed argument checking for `utrace`.
* Fixed argument checking for `clock_nanosleep`.