Create valgrind.adoc #352
Closed
Create valgrind.adoc #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valgrind news.
pauamma
reviewed
Mar 17, 2024
Comment on lines
22
to
33
| smaller bugfixes. | ||
|
|
||
| Support for FreeBSD 13.3 has been added. | ||
| Added a redirect for `reallocarray`. | ||
| Several fixes for `aio*` functions. | ||
| Added a redirect for `memccpy`. | ||
| There is a fix for `_umtx_op OP_ROBUST_LISTS`. | ||
| Added redirs for C23 `free_sized` and `free_aligned_sized`. | ||
| Correctly propagate the ELF stack protection flags to the guest stack that Valgrind synthesizes. | ||
| Fixes for `--sanity-level-3` and above (only used for Valgrind self-testing at runtime). | ||
| Aeveral fixes to checking done for `semctl`. | ||
| Fixed argument checking for `utrace`. |
There was a problem hiding this comment.
Is this meant to be a bullet list with "smaller bugfixes" as the list header?
One typo fix.
Make a bullet lit and add a fix done today.
pauamma
approved these changes
Mar 18, 2024
| * Several fixes for `aio*` functions. | ||
| * Added a redirect for `memccpy`. | ||
| * There is a fix for `_umtx_op OP_ROBUST_LISTS`. | ||
| * Added redirs for C23 `free_sized` and `free_aligned_sized`. |
There was a problem hiding this comment.
Suggested change
| * Added redirs for C23 `free_sized` and `free_aligned_sized`. | |
| * Added redirects for C23 `free_sized` and `free_aligned_sized`. |
| * Added a redirect for `memccpy`. | ||
| * There is a fix for `_umtx_op OP_ROBUST_LISTS`. | ||
| * Added redirs for C23 `free_sized` and `free_aligned_sized`. | ||
| * Correctly propagate the ELF stack protection flags to the guest stack that Valgrind synthesizes. |
There was a problem hiding this comment.
Suggested change
| * Correctly propagate the ELF stack protection flags to the guest stack that Valgrind synthesizes. | |
| * Correctly propagated the ELF stack protection flags to the guest stack that Valgrind synthesizes. |
There was a problem hiding this comment.
No, it should be present continuous, this is something that gets done at every startup. Previously this was hard coded and did not respect the guest stack protection flags.
lsalvadore
reviewed
Mar 20, 2024
| The major news, as per the title, is that a port to FreeBSD arm64 (or aarch64) is now ready. | ||
| The next steps are to get it reviewed and pushed upstream. | ||
|
|
||
| Valgrind 3.23 due out at the end of April 2024 and package:devel/valgrind[] will be updated shortly after that. |
There was a problem hiding this comment.
Mind that I am not a native English speaker, but this does not sound right to me. Maybe
Suggested change
| Valgrind 3.23 due out at the end of April 2024 and package:devel/valgrind[] will be updated shortly after that. | |
| Valgrind 3.23 is due out at the end of April 2024 and package:devel/valgrind[] will be updated shortly after that. |
|
|
||
| Valgrind 3.23 due out at the end of April 2024 and package:devel/valgrind[] will be updated shortly after that. | ||
|
|
||
| package:devel/valgrind-devel[] will get an update as soon as I've pushed the changes for arm64. |
There was a problem hiding this comment.
Please avoid contractions.
Suggested change
| package:devel/valgrind-devel[] will get an update as soon as I've pushed the changes for arm64. | |
| package:devel/valgrind-devel[] will get an update as soon as I have pushed the changes for arm64. |
freebsd-git
pushed a commit
that referenced
this pull request
Mar 21, 2024
Reviewed by: status (Pau Amma <pauamma@gundo.com>) Pull Request: #352
|
Merged with the approved small changes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valgrind news.