Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn about legacy suffix use #1298

Merged
merged 8 commits into from Apr 30, 2024
Merged

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Apr 26, 2024

What does this PR do?

  • adds a warning when people use the legacy indexe suffix to help speed migration
  • restore backward compatibility support for indexe

What issues does this PR fix or reference?

forcedotcom/cli#2847
@W-15631183@

QA: I was able to test this using https://github.com/jongpie/NebulaLogger/tree/8e6730e8fec1f287798e5c088c2a94cda1ba83bd/nebula-logger/plugins/big-object-archiving/plugin/objects/LogEntryArchive__b/indexes
using convert source

@mshanemc mshanemc added the bug Something isn't working label Apr 26, 2024
@mshanemc mshanemc marked this pull request as ready for review April 29, 2024 19:02
@mshanemc mshanemc requested a review from a team as a code owner April 29, 2024 19:02
@WillieRuemmele
Copy link
Member

QA Notes


✅ : linked SDR -> PDR -> CLI

 ➜  sf project convert source --source-dir nebula-logger/plugins/big-object-archiving/plugin/objects/LogEntryArchive__b/indexes
Warning: The Index component at /Users/william.ruemmele/projects/scratches/NebulaLogger/nebula-logger/plugins/big-object-archiving/plugin/objects/LogEntryArchive__b/indexes/LogEntryArchiveIndex.indexe-meta.xml uses the legacy suffix indexe. This suffix is deprecated and will be removed in a future release.
Source was successfully converted to Metadata API format and written to the location: /Users/william.ruemmele/projects/scratches/NebulaLogger/metadataPackage_1714514426488

✅ : no .indexe-meta.xml, no warning

@WillieRuemmele WillieRuemmele merged commit 6ad87d2 into main Apr 30, 2024
68 checks passed
@WillieRuemmele WillieRuemmele deleted the sm/legacy-suffix-fix branch April 30, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants