Skip to content

Commit

Permalink
feat: also check legacy suffix for strict folder matching
Browse files Browse the repository at this point in the history
  • Loading branch information
mshanemc committed Apr 30, 2024
1 parent 9426b45 commit 80c8699
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/resolve/metadataResolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -385,8 +385,11 @@ const resolveTypeFromStrictFolder =
.filter(folderTypeFilter(fsPath))
.find(
(type) =>
// any of the following 3 options is considered a good match
isMixedContentOrBundle(type) || suffixMatches(type, fsPath) || childSuffixMatches(type, fsPath)
// any of the following options is considered a good match
isMixedContentOrBundle(type) ||
suffixMatches(type, fsPath) ||
childSuffixMatches(type, fsPath) ||
legacySuffixMatches(type, fsPath)
);
};

Expand Down

2 comments on commit 80c8699

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 80c8699 Previous: 9426b45 Ratio
eda-componentSetCreate-linux 186 ms 176 ms 1.06
eda-sourceToMdapi-linux 1929 ms 2842 ms 0.68
eda-sourceToZip-linux 1387 ms 1378 ms 1.01
eda-mdapiToSource-linux 2780 ms 2801 ms 0.99
lotsOfClasses-componentSetCreate-linux 404 ms 389 ms 1.04
lotsOfClasses-sourceToMdapi-linux 3584 ms 3827 ms 0.94
lotsOfClasses-sourceToZip-linux 3027 ms 3133 ms 0.97
lotsOfClasses-mdapiToSource-linux 3428 ms 3578 ms 0.96
lotsOfClassesOneDir-componentSetCreate-linux 625 ms 630 ms 0.99
lotsOfClassesOneDir-sourceToMdapi-linux 6520 ms 7518 ms 0.87
lotsOfClassesOneDir-sourceToZip-linux 5561 ms 5827 ms 0.95
lotsOfClassesOneDir-mdapiToSource-linux 6395 ms 6484 ms 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 80c8699 Previous: 9426b45 Ratio
eda-componentSetCreate-win32 443 ms 384 ms 1.15
eda-sourceToMdapi-win32 3823 ms 3504 ms 1.09
eda-sourceToZip-win32 2331 ms 2146 ms 1.09
eda-mdapiToSource-win32 6282 ms 5768 ms 1.09
lotsOfClasses-componentSetCreate-win32 940 ms 842 ms 1.12
lotsOfClasses-sourceToMdapi-win32 8322 ms 7773 ms 1.07
lotsOfClasses-sourceToZip-win32 5240 ms 4834 ms 1.08
lotsOfClasses-mdapiToSource-win32 8275 ms 7636 ms 1.08
lotsOfClassesOneDir-componentSetCreate-win32 1501 ms 1517 ms 0.99
lotsOfClassesOneDir-sourceToMdapi-win32 13886 ms 14019 ms 0.99
lotsOfClassesOneDir-sourceToZip-win32 8402 ms 8804 ms 0.95
lotsOfClassesOneDir-mdapiToSource-win32 13544 ms 13873 ms 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.