Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Allows animations to be paused *now* #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seosgithub
Copy link

Calls to _render will automatically enable pause, this wouldn't be an issue but the call to _render is called at some time in the future (especially if CADisplayLink is not configured). This patch allows you to use state.paused = true at creation time. By default, the animation will start in a non-paused state

Calls to _render will automatically enable pause, this wouldn't be an issue but the call to _render is called at some time in the future (especially if CADisplayLink is not configured).  This patch allows you to use state.paused = true at creation time.  By default, the animation will start in a non-paused state
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@seosgithub
Copy link
Author

I'll take a deeper look into this later. One of the tests is trying to report a value that hasn't been initialized because POPAnimation.mm:496 is never reached because of 'if (state->active && !state->paused) {
' (which would have initialized outVec, and paused is now false to boot)'.

@ghost
Copy link

ghost commented Feb 19, 2015

Code request

@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants