Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return custom hardforks properly #3367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return custom hardforks properly #3367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/common/src/common.ts
View file
Open in desktop
Expand Up @@ -962,7 +962,7 @@ export class Common {
hardforks(): HardforkTransitionConfig[] {
const hfs = this._chainParams.hardforks
if (this._chainParams.customHardforks !== undefined) {
this._chainParams.customHardforks
return this._chainParams.customHardforks
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure what the goal of this code was, but it seems to be wrong without the return.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is this meant to do concatenation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this but I have no idea what it was supposed to do 🤔 Have to check, maybe this indeed should be concatenation 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this commit afabbec I added it, with a test, so I apparently thought that this "new logic" was necessary in order to support those custom hardforks 🤔

}
return hfs
}
Expand Down