Return custom hardforks properly #3367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Apr 24, 2024
| @@ -962,7 +962,7 @@ export class Common { | |||
| hardforks(): HardforkTransitionConfig[] { | |||
| const hfs = this._chainParams.hardforks | |||
| if (this._chainParams.customHardforks !== undefined) { | |||
| this._chainParams.customHardforks | |||
| return this._chainParams.customHardforks | |||
There was a problem hiding this comment.
I'm not 100% sure what the goal of this code was, but it seems to be wrong without the return.
There was a problem hiding this comment.
Or is this meant to do concatenation?
There was a problem hiding this comment.
I added this but I have no idea what it was supposed to do 🤔 Have to check, maybe this indeed should be concatenation 🤔
There was a problem hiding this comment.
In this commit afabbec I added it, with a test, so I apparently thought that this "new logic" was necessary in order to support those custom hardforks 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.