chargent: fix manual/tap hiding of notification #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thyttan does this fix that notification problem? |
I tried this the other day and no, not for my setup as it seemed... 🤷♂️ |
|
Interesting - it fixes the exception from |
|
I'm sorry - much of this has probably been user error on my part :) After reading the readme more carefully I see it's supposed to warn when battery indication in UI said 100 % for a few minutes. I mistakenly believed it should have buzzed at UI indication 80 %. |
|
Thanks! |
|
Ah no worries! Thanks for helping test it out - wouldn't have found the fix without you :) |
bobrippling
added a commit
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by and documented in #3262.
This also shortens the message length to fit on the screen