-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chargent: allow a tap on the notification to silence it #3262
chargent: allow a tap on the notification to silence it #3262
Conversation
@thyttan would you be ok with me merging this? (or ok to merge it?) |
Don't know if it's this PR or something else, but I just installed v0.06 on my watch and attached the charging cable. Started on ~60% went past both 80% and 90% without signaling. fw 2v21.51. |
Interesting, I'll take a look |
I'll try again as well when the battery has come down, and connect with the web ide to look for errors. |
I tried again but with v0.05 from standard dev app loader, also no reaction going from 75% to 85% (fw 2v21.53). So maybe something particular is up with my setup. Does it work for you? |
And now I've tried v0.05 after a factory reset on fw 2v21.53 - still no reaction on my watch. |
That's strange, I see the notification when I charge mine ok, I wonder - do you see it if you allow your watch to sit at full charge for 5 mins? |
Then I think go ahead with merging 👍 Do you want me to do it? As for my watch, I'll try you suggestion 🙂 |
Thanks! Yeah let's see if we get more reports and I'll keep my eye on it, let me know if you still see issues and we can debug, even if it's an unrelated problem :) |
Charged 25% -> 100% today without noticing warning buzzes. I wasn't around it for the whole duration. When I got back it said 'Fully charged' over the widget field, some of the text went past the screen edge. The only way I got it to disappear was doing a regular |
Thanks, sounds like there's a bug - I'll see if I've any odd local config that might be interfering. I also see the notification part-way off the screen, which I'll sort a fix for |
I think I didn't.test without fastload utils - maybe that's the culprit? |
Yes I suspect so - I've seen similar issues / possibly watch hangs when charging, need to investigate still though |
I suspected it might be a problem with interaction of |
Cracked it - #3386 |
This allows a user to silence the buzz/notification once seen