Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prefer-immutable-types): allow overriding options based on where the type is declared #804

Open
wants to merge 1 commit into
base: 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
Choose a base branch
from
Open

feat(prefer-immutable-types): allow overriding options based on where the type is declared #804

wants to merge 1 commit into from

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Apr 14, 2024 •
edited

Fix #800

@RebeccaStevens
Copy link
Collaborator Author

RebeccaStevens commented Apr 14, 2024 •
edited

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RebeccaStevens and the rest of your teammates on Graphite Graphite

@RebeccaStevens RebeccaStevens mentioned this pull request Apr 14, 2024
Open
@RebeccaStevens RebeccaStevens marked this pull request as ready for review April 14, 2024 14:04
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 0a6bd90 to f31eb30 Compare April 14, 2024 14:13
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 0130f0f to 63f36f3 Compare April 14, 2024 14:13
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from f31eb30 to c24ea84 Compare April 14, 2024 14:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 63f36f3 to d246ac3 Compare April 14, 2024 14:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from c24ea84 to bf25112 Compare April 14, 2024 14:27
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from d246ac3 to 7c09967 Compare April 14, 2024 14:27
@RebeccaStevens
Copy link
Collaborator Author

We probably want to bump the minimum ts version up to 4.7

@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from bf25112 to 8bfc725 Compare April 15, 2024 06:54
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 7c09967 to d33e2c7 Compare April 15, 2024 06:54
@RebeccaStevens RebeccaStevens mentioned this pull request Apr 15, 2024
Closed
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 8bfc725 to 20f7137 Compare April 15, 2024 08:33
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from d33e2c7 to 78839d6 Compare April 15, 2024 08:33
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 20f7137 to 61e4e86 Compare April 16, 2024 09:34
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 78839d6 to a1a2526 Compare April 16, 2024 09:34
@RebeccaStevens RebeccaStevens mentioned this pull request Apr 16, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 61e4e86 to 90bb5eb Compare April 17, 2024 12:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from a1a2526 to f62f410 Compare April 17, 2024 12:16
This was referenced Apr 18, 2024
Open
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 90bb5eb to 71364aa Compare April 22, 2024 12:33
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from f62f410 to 414f358 Compare April 22, 2024 12:33
@RebeccaStevens RebeccaStevens mentioned this pull request Apr 22, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 71364aa to 4a927d8 Compare April 22, 2024 15:25
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 414f358 to 389d79d Compare April 22, 2024 15:25
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 4a927d8 to 8387695 Compare April 22, 2024 16:03
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 389d79d to dd561f5 Compare April 22, 2024 16:03
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 8387695 to 854b721 Compare April 30, 2024 06:05
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 0903137 to 2c6e45b Compare May 6, 2024 10:23
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from e61e30a to c3b3266 Compare May 6, 2024 11:05
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 2c6e45b to a09d559 Compare May 6, 2024 11:06
@RebeccaStevens RebeccaStevens mentioned this pull request May 6, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from c3b3266 to 8cf75a2 Compare May 6, 2024 11:30
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from a09d559 to 0b09d6f Compare May 6, 2024 11:30
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 8cf75a2 to 3f2bfb9 Compare May 6, 2024 12:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 0b09d6f to ff3c821 Compare May 6, 2024 12:16
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 3f2bfb9 to e205e84 Compare May 7, 2024 00:19
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from ff3c821 to 08152bb Compare May 7, 2024 00:19
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from e205e84 to bd0edd0 Compare May 9, 2024 23:55
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 08152bb to b7d0cf8 Compare May 9, 2024 23:55
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from bd0edd0 to f988172 Compare May 12, 2024 06:09
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from b7d0cf8 to da6f22d Compare May 12, 2024 06:09
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from f988172 to aa3c1d8 Compare May 19, 2024 03:27
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from da6f22d to e98de95 Compare May 19, 2024 03:27
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from aa3c1d8 to fbc6119 Compare May 25, 2024 10:23
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from e98de95 to a20d63e Compare May 25, 2024 10:23
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from fbc6119 to c845f8e Compare May 25, 2024 11:08
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from a20d63e to f730ae6 Compare May 25, 2024 11:08
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from c845f8e to 641b8b0 Compare May 25, 2024 11:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from f730ae6 to 0713a0f Compare May 25, 2024 11:16
@RebeccaStevens RebeccaStevens mentioned this pull request May 25, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 641b8b0 to 0e3f642 Compare May 25, 2024 12:39
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 0713a0f to 67f5e6e Compare May 25, 2024 12:39
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 0e3f642 to 5bd3589 Compare May 25, 2024 13:32
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 67f5e6e to ac98f6b Compare May 25, 2024 13:32
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 5bd3589 to 4c7cafd Compare May 26, 2024 05:11
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from ac98f6b to 525eb6a Compare May 26, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@RebeccaStevens