Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(functional-parameters): allow overriding options based on where the function type is declared #803

Open
wants to merge 1 commit into
base: 04-23-part_set_up_overridable_options
Choose a base branch
from
Open

feat(functional-parameters): allow overriding options based on where the function type is declared #803

wants to merge 1 commit into from
+441 −94

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Apr 14, 2024 •
edited

Fix #575

@RebeccaStevens
Copy link
Collaborator Author

RebeccaStevens commented Apr 14, 2024 •
edited

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RebeccaStevens and the rest of your teammates on Graphite Graphite

@RebeccaStevens RebeccaStevens mentioned this pull request Apr 14, 2024
Open
@RebeccaStevens RebeccaStevens marked this pull request as ready for review April 14, 2024 14:03
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch 4 times, most recently from bf25112 to 8bfc725 Compare April 15, 2024 06:54
@RebeccaStevens RebeccaStevens mentioned this pull request Apr 15, 2024
Closed
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 8bfc725 to 20f7137 Compare April 15, 2024 08:33
@RebeccaStevens RebeccaStevens changed the base branch from main to 04-15-feat_eslint_9_migration April 16, 2024 09:34
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 20f7137 to 61e4e86 Compare April 16, 2024 09:34
@RebeccaStevens RebeccaStevens mentioned this pull request Apr 16, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 61e4e86 to 90bb5eb Compare April 17, 2024 12:16
This was referenced Apr 18, 2024
Open
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 90bb5eb to 71364aa Compare April 22, 2024 12:33
@RebeccaStevens RebeccaStevens changed the base branch from 04-15-feat_eslint_9_migration to 04-23-part_set_up_overridable_options April 22, 2024 12:33
@RebeccaStevens RebeccaStevens mentioned this pull request Apr 22, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from 2a8bbbc to ffaaa6b Compare April 22, 2024 15:25
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 71364aa to 4a927d8 Compare April 22, 2024 15:25
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from ffaaa6b to 9674e31 Compare April 22, 2024 16:02
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 4a927d8 to 8387695 Compare April 22, 2024 16:03
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from 9674e31 to 384b848 Compare April 30, 2024 06:05
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 8387695 to 854b721 Compare April 30, 2024 06:05
@RebeccaStevens RebeccaStevens mentioned this pull request May 3, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from 384b848 to be6f209 Compare May 6, 2024 01:01
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 854b721 to f4d9ce0 Compare May 6, 2024 01:01
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from be6f209 to a8aaa5c Compare May 6, 2024 01:17
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from 3594989 to 7ff9d4d Compare May 6, 2024 10:23
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch 2 times, most recently from fb1040c to 6bbfcf5 Compare May 6, 2024 11:05
@RebeccaStevens RebeccaStevens mentioned this pull request May 6, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from 7ff9d4d to 64265b3 Compare May 6, 2024 11:30
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 6bbfcf5 to c20ff58 Compare May 6, 2024 11:30
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from 64265b3 to 65512ff Compare May 6, 2024 12:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from c20ff58 to afb8d3e Compare May 6, 2024 12:16
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from 65512ff to 6c3e72d Compare May 7, 2024 00:19
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from afb8d3e to 0de23fb Compare May 7, 2024 00:19
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from 6c3e72d to 74a30d2 Compare May 9, 2024 23:55
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 0de23fb to 460d155 Compare May 9, 2024 23:55
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from 74a30d2 to 7ea1b6a Compare May 12, 2024 06:09
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 460d155 to e8e803c Compare May 12, 2024 06:09
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from 7ea1b6a to 84c6249 Compare May 19, 2024 03:27
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from e8e803c to de6f6f9 Compare May 19, 2024 03:27
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from 84c6249 to 381133a Compare May 25, 2024 10:23
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from de6f6f9 to 005df0d Compare May 25, 2024 10:23
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from 381133a to 22f8704 Compare May 25, 2024 11:08
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 005df0d to c14c02e Compare May 25, 2024 11:08
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from 22f8704 to ea35fa4 Compare May 25, 2024 11:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from c14c02e to dee726e Compare May 25, 2024 11:16
@RebeccaStevens RebeccaStevens mentioned this pull request May 25, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from ea35fa4 to 7fdbac0 Compare May 25, 2024 12:39
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from dee726e to 973d1c4 Compare May 25, 2024 12:39
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from 7fdbac0 to e1fe980 Compare May 25, 2024 13:32
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 973d1c4 to 3e48bb8 Compare May 25, 2024 13:32
@RebeccaStevens RebeccaStevens force-pushed the 04-23-part_set_up_overridable_options branch from e1fe980 to 1865b29 Compare May 26, 2024 05:11
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 3e48bb8 to 1473754 Compare May 26, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

functional/functional-parameters Limit only to specific types
1 participant
@RebeccaStevens