Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slack-webhook library #35

Closed
wants to merge 8 commits into from
Closed

Use slack-webhook library #35

wants to merge 8 commits into from

Commits on Sep 23, 2016

  1. Configuration menu
    Copy the full SHA
    72f6812 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    38eeb9c View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2016

  1. Use slack-webhook library

    We were previously building the json payload ourselves. Now, we off-load
    that work onto a library which is made for this purpose.
    
    This is just an initial shim that works. We probably need to ditch the
    SlackPayload class entirely favoring a SlackMessage Factory that does
    the work currently in the SlackPayload constructor.
    eljobe committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    b8828ab View commit details
    Browse the repository at this point in the history
  2. Change the placeholder text

    Before this change, the Verbose setting wasn't able to be set to `True`
    because it was the same value as the placeholder text.
    eljobe committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    2e2601f View commit details
    Browse the repository at this point in the history
  3. Make the source compatible with 1.7

    This also cleans up a few warnings from the IDE
    eljobe committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    fce3077 View commit details
    Browse the repository at this point in the history
  4. Replace SlackPayload with MessageFactory

    This simplifies what is essentially a functional operation into a static
    function.
    eljobe committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    dd3c6b3 View commit details
    Browse the repository at this point in the history
  5. Fix a typo

    eljobe committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    a774b23 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2016

  1. Remove extraneous "this."

    eljobe committed Sep 28, 2016
    Configuration menu
    Copy the full SHA
    1f9357a View commit details
    Browse the repository at this point in the history