Use slack-webhook library #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously building the json payload ourselves. Now, we off-load that work onto a library which is made for this purpose. This is just an initial shim that works. We probably need to ditch the SlackPayload class entirely favoring a SlackMessage Factory that does the work currently in the SlackPayload constructor.
Before this change, the Verbose setting wasn't able to be set to `True` because it was the same value as the placeholder text.
This also cleans up a few warnings from the IDE
This simplifies what is essentially a functional operation into a static function.
|
I'm guessing this is not going to be merged. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% happy with this change. It definitely simplifies the creation of slack messages from the data that is generated by the TeamCity build status events. However, I notice that the
SlackWrapperclass is basically a useless abstraction in the current way the code is organized.For each event the
SlackNotificatorreceives and each user in the set of users who need to be notified for this event, we instantiate a newSlackWrapperand then callsendon that wrapper instance. But, we never need to reuse any of the state on theSlackWrapperobject, so, we might as well just be passing the data straight through instead of storing it on an object.I'd like to get this much of the code integrated into the project as it provides some benefit (no longer need the
SlackPayloadclass.) But, then I'm going to continue restructuring theSlackNotificatorsuch that it's job is basically to:TeamCityEventobject which describes what happened from TeamCity's point of view (e.g. The build failed.)SlackTargetobject which describes the data we currently keep onSlackWrapperand then passes thatSet<SlackTarget>andTeamCityEventto a new version ofSlackWrapper.send()which will just be responsible for creating aSlackMessageand sending it to theSlackApifor eachSlackTargetandTeamCityEventThis way, we can construct theSlackWrapperonly once and cache instances ofSlackApibased on theslackUrlfrom which they are constructed.If you'd prefer, I can go ahead and work on those changes as part of this pull request, but this code is working, so I'd prefer to get it checked in, and then add these other pieces incrementally.