[Ent Search] Update Playground copy #181951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leemthompo
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
leemthompo
commented
Apr 29, 2024
x-pack/plugins/search_playground/public/components/edit_context/edit_context_flyout.tsx
Show resolved
Hide resolved
joemcelroy
approved these changes
Apr 29, 2024
|
thanks for those updates! |
leemthompo
commented
Apr 29, 2024
| <p> | ||
| <FormattedMessage | ||
| id="xpack.searchPlayground.startNewChat.description" | ||
| defaultMessage="Combine your Elasticsearch data with the power of large language models for retrieval augmented generation (RAG). Use the UI to view and edit the Elasticsearch queries used to search your data, then download the code to integrate into your own application." |
There was a problem hiding this comment.
@julianrosado for your eyes only
There was a problem hiding this comment.
Looks... good to me. :: Nod ::
Samiul-TheSoccerFan
approved these changes
Apr 29, 2024
| @@ -40,7 +40,7 @@ export const CreateIndexCallout: React.FC = () => { | |||
| <p> | |||
| <FormattedMessage | |||
| id="xpack.searchPlayground.sources.createIndexCallout.description" | |||
| defaultMessage="You can not continue without having at least one index with data to search." | |||
| defaultMessage="You need at least one index with data to search. " | |||
There was a problem hiding this comment.
nitpik: Is the last space intentional?
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 29, 2024
(cherry picked from commit 7fa867c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 29, 2024
# Backport This will backport the following commits from `main` to `8.14`: - [[Ent Search] Update Playground copy (#181951)](#181951) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Liam Thompson","email":"32779855+leemthompo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-04-29T15:54:05Z","message":"[Ent Search] Update Playground copy (#181951)","sha":"7fa867cdd70251b30e007888840a66ccd5f57098","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.14.0","v8.15.0"],"title":"[Ent Search] Update Playground copy","number":181951,"url":"#181951 Search] Update Playground copy (#181951)","sha":"7fa867cdd70251b30e007888840a66ccd5f57098"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#181951 Search] Update Playground copy (#181951)","sha":"7fa867cdd70251b30e007888840a66ccd5f57098"}}]}] BACKPORT--> Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number of changes discussed with @joemcelroy and @julianrosado. I've made a few tweaks based on how stuff looks.
Text for the main overview:
TODOxpack.searchPlayground.editContext.flyout.descriptionCan just link to existing Playground doc link.