Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor adjustments: use ROS_INFO(), and publish timestamped messages #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZeppLu
Copy link
Contributor

@ZeppLu ZeppLu commented Jul 23, 2020

Some adjustments I personally consider helpful, but don't know whether they fit everyone, so feel free to reject this PR.

In my case, pros of timestamped message:

  • you can measure latency with rostopic delay <topic>
  • if image and detection message is published separately, you can match them up by looking into their timestamps

@dusty-nv
Copy link
Owner

Thanks @ZeppLu, I am currently refactoring the nodes to add support for ROS2 (in addition to retaining support for ROS1). I will merge these changes into ros2 branch, which will then be merged back into master relatively soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants