Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EOL 2.7 #228

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Remove EOL 2.7 #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
111 changes: 0 additions & 111 deletions 2.7/Dockerfile
View file
Open in desktop

This file was deleted.

103 changes: 0 additions & 103 deletions 2.7/alpine/Dockerfile
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions 2.7/alpine/docker-entrypoint.sh
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions 2.7/docker-entrypoint.sh
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion Dockerfile.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ ENV HAPROXY_SHA256 {{ .sha256 }}
# Since 5.4 is supported on haproxy, better use it now, but only for
# newer versions since there could be some minor incompatibilities
# for existing scripts: https://www.lua.org/manual/5.4/manual.html#8
if ([ "2.0", "2.2", "2.4", "2.6", "2.7", "2.8" ] | index(env.version)) then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimWolla 2.0 is also out of LTS and also EOL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.0 is not EOL.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i found 2 sources that said it is and one that was ambiguous. It can be done in a separate PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what sources you used, but the official project homepage does not list HAProxy 2.0 as EOL: https://www.haproxy.org/. And neither does yesterday's release announcement of HAProxy 2.0.35 (whereas the one for 2.7.12 did): https://www.mail-archive.com/haproxy@formilux.org/

if ([ "2.0", "2.2", "2.4", "2.6", "2.8" ] | index(env.version)) then
"5.3"
else
"5.4"
Expand Down
7 changes: 0 additions & 7 deletions versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,6 @@
"url": "https://www.haproxy.org/download/2.6/src/haproxy-2.6.17.tar.gz",
"version": "2.6.17"
},
"2.7": {
"alpine": "3.19",
"debian": "bookworm-slim",
"sha256": "471d42524049b37b5fc79093ac26911a838c2c67a18bd2f8d01efd48a83a362c",
"url": "https://www.haproxy.org/download/2.7/src/haproxy-2.7.12.tar.gz",
"version": "2.7.12"
},
"2.8": {
"alpine": "3.19",
"debian": "bookworm-slim",
Expand Down