Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EOL 2.7 #228

Merged
merged 1 commit into from Apr 8, 2024
Merged

Remove EOL 2.7 #228

merged 1 commit into from Apr 8, 2024

Conversation

TimWolla
Copy link
Contributor

@TimWolla TimWolla commented Apr 6, 2024

No description provided.

@@ -59,7 +59,7 @@ ENV HAPROXY_SHA256 {{ .sha256 }}
# Since 5.4 is supported on haproxy, better use it now, but only for
# newer versions since there could be some minor incompatibilities
# for existing scripts: https://www.lua.org/manual/5.4/manual.html#8
if ([ "2.0", "2.2", "2.4", "2.6", "2.7", "2.8" ] | index(env.version)) then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimWolla 2.0 is also out of LTS and also EOL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.0 is not EOL.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i found 2 sources that said it is and one that was ambiguous. It can be done in a separate PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what sources you used, but the official project homepage does not list HAProxy 2.0 as EOL: https://www.haproxy.org/. And neither does yesterday's release announcement of HAProxy 2.0.35 (whereas the one for 2.7.12 did): https://www.mail-archive.com/haproxy@formilux.org/

@yosifkit
Copy link
Member

yosifkit commented Apr 8, 2024

We'll wait until after docker-library/official-images#16555, so that we push the final release.

@tianon
Copy link
Member

tianon commented Apr 8, 2024

(Rebased thanks to #226 😅)

@tianon
Copy link
Member

tianon commented Apr 8, 2024

and now docker-library/official-images#16555 is not just merged but fully built and published 🚀

@tianon
Copy link
Member

tianon commented Apr 8, 2024

I don't think we really need to wait for CI here 😄

@tianon tianon merged commit 1cae2e3 into docker-library:master Apr 8, 2024
29 of 30 checks passed
@TimWolla TimWolla deleted the 2.7-eol branch April 8, 2024 22:01
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Apr 8, 2024
Changes:

- docker-library/haproxy@1cae2e3: Merge pull request docker-library/haproxy#228 from TimWolla/2.7-eol
- docker-library/haproxy@2dbe02f: Remove EOL 2.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants