refactor(collections): unify function overloads #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
bartlomieju
approved these changes
Nov 19, 2023
kt3k
added a commit
to kt3k/deno_std
that referenced
this pull request
Nov 21, 2023
This reverts commit 835f4f6.
kt3k
added a commit
to kt3k/deno_std
that referenced
this pull request
Nov 21, 2023
kt3k
added a commit
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor combines multiple function overloads within
std/collections. The functions are now easier to understand, and the documentation required for this module has been reduced.More functions can be cleaned up in follow-up PRs.
Towards #3764