docs(collection): document overloads (revert #3818) #3823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3818 removed overloads from several functions, but they seemed useful. Now these functions accept selectors of mixed return types such as
maxBy(arr, (item) => item === null ? 10 : "foo")
and what happens with these calls are not obvious (also not documented). I think we shouldn't allow these calls.This PR instead documents all overloads of these functions towards #3764