Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreman does not terminate child process #779

Open
baelter opened this issue Jun 16, 2021 · 3 comments · Fixed by spinels/overman#1 · May be fixed by #780
Open

Foreman does not terminate child process #779

baelter opened this issue Jun 16, 2021 · 3 comments · Fixed by spinels/overman#1 · May be fixed by #780

Comments

@baelter
Copy link

baelter commented Jun 16, 2021

Same issue as #628

Procfile:

worker: ruby test.rb

test.rb

pid = Process.spawn("sleep 100")
Process.detach(pid)
sleep

Steps to repoduce:

  1. $ foreman start
  2. $ kill <foreman-pid>
  3. Spawned process is still running
@dentarg dentarg linked a pull request Jun 26, 2021 that will close this issue
Open
@dentarg
Copy link

dentarg commented Jun 26, 2021

I think #723 addresses this issue. I rebased that branch against latest master, feel free to try it out: https://github.com/dentarg/foreman/tree/pgroup

This was referenced Oct 28, 2022
Closed
Merged
@dentarg
Copy link

dentarg commented Oct 28, 2022

I forked foreman and merged #780 (#723 but rebased) and released the fork as overman: https://github.com/spinels/overman, https://rubygems.org/gems/overman, #780 (comment)

This was referenced Oct 28, 2022
Open
Open
Open
@dentarg dentarg mentioned this issue Dec 17, 2022
Open
@jdelStrother
Copy link

@dentarg thanks for overman, I've replaced foreman with it in our dev setup.

@glaucocustodio glaucocustodio mentioned this issue Feb 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jdelStrother @dentarg @baelter