fix: getDatabaseBackups() should check error on .downloads deletion

[rfay]

The Issue

From https://discord.com/channels/664580571770388500/1232668554550186024/1232668554550186024

The .ddev/.downloads/files directory may exist somehow when trying to just get databases.

Currently in HEAD ddev pull ignores failure to delete and recreate the .downloads directory.

How This PR Solves The Issue

Check the error.

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

[github-actions]

Download the artifacts for this pull request:

• all-ddev-executables.zip
• ddev-linux-amd64.zip
• ddev-linux-arm64.zip
• ddev-macos-amd64.zip
• ddev-macos-arm64.zip
• ddev-windows-amd64-installer.zip

See Testing a PR.

• Test on Gitpod.
• Test on GitHub Codespaces.

[stasadev]

GetBackup() has a call to prepDownloadDir():

ddev/pkg/ddevapp/provider.go

Lines 211 to 218 in 6cb2569

	func (p *Provider) GetBackup(backupType string) ([]string, []string, error) {
	var err error
	var fileNames []string
	if backupType != "database" && backupType != "files" {
	return nil, nil, fmt.Errorf("could not get backup: %s is not a valid backup type", backupType)
	}
	p.prepDownloadDir()

And prepDownloadDir() recreates files directory:

ddev/pkg/ddevapp/provider.go

Lines 290 to 297 in 6cb2569

	// prepDownloadDir ensures the download cache directories are created and writeable.
	func (p *Provider) prepDownloadDir() {
	destDir := p.getDownloadDir()
	filesDir := filepath.Join(destDir, "files")
	_ = os.RemoveAll(destDir)
	err := os.MkdirAll(filesDir, 0755)
	util.CheckErr(err)
	}

The .ddev/.downloads/files directory may exist somehow when trying to just get databases.

prepDownloadDir() does not check the type of backup (from backupType) and always creates files.

[stasadev]

Hmm, I looked at the code again, and the .ddev/.downloads (or .ddev/.downloads/files) directory is deleted and then created again later.

But in any case, if files dir is created all the time before call to getDatabaseBackups(), then if the next command fails, it will remain, the check added here is correct.

[rfay]

But in any case, if files dir is created all the time before call to getDatabaseBackups(), then if the next command fails, it will remain, the check added here is correct.

Agreed.

The support issue in Discord appears to be something going wrong with mutagen or mutagen configuration. Even though mutagen sync is done, the files directory still exists.