fix: getDatabaseBackups should check error on .downloads deletion

ddev · May 2, 2024 · f028a22 · f028a22
1 parent 3a821f3
commit f028a22
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/pkg/ddevapp/provider.go b/pkg/ddevapp/provider.go
@@ -325,8 +325,14 @@ func (p *Provider) doFilesPullCommand() (filename []string, error error) {
 // getDatabaseBackups retrieves database using `generic backup database`, then
 // describe until it appears, then download it.
 func (p *Provider) getDatabaseBackups() (filename []string, error error) {
-	_ = os.RemoveAll(p.getDownloadDir())
-	_ = os.Mkdir(p.getDownloadDir(), 0755)
+	err := os.RemoveAll(p.getDownloadDir())
+	if err != nil {
+		return nil, err
+	}
+	err = os.Mkdir(p.getDownloadDir(), 0755)
+	if err != nil {
+		return nil, err
+	}
 
 	if p.DBPullCommand.Command == "" {
 		return nil, nil
@@ -336,7 +342,7 @@ func (p *Provider) getDatabaseBackups() (filename []string, error error) {
 	if s == "" {
 		s = "web"
 	}
-	err := p.app.MutagenSyncFlush()
+	err = p.app.MutagenSyncFlush()
 	if err != nil {
 		return nil, err
 	}