Changes to allow building wasm csound using emscripten, cmake and vckpg

[nonameentername]

Changes to allow building wasm csound using emscripten, cmake and vckpg

[gogins]

Are you using the Emscripten wrapper for CMake, as you should be? I.e. "emcmake cmake ..." Regards, Mike

…

----------------------------------------------------- Michael Gogins Irreducible Productions http://michaelgogins.tumblr.com Michael dot Gogins at gmail dot com

On Wed, Dec 27, 2023 at 8:05 PM werner mendizabal ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In CMakeLists.txt <#1797 (comment)>: > @@ -12,7 +12,9 @@ option(USE_VCPKG "Use VCPKG to download and manage dependencies" OFF) if (USE_VCPKG) # Detect correct triplet based on CMake env - if (WIN32) + if (CMAKE_SYSTEM_NAME STREQUAL "Emscripten") The variable EMSCRIPTEN was not available here. Maybe I'm missing something when configuring cmake? — Reply to this email directly, view it on GitHub <#1797 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQIGJM5QPP7ZEEQE67DM7DYLTAULAVCNFSM6AAAAABA62NW3OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJXGU4DMNZRHE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[kunstmusik]

I'm just back from holidays but won't be able to review until next week. We previously built Csound with Emscripten and as far as I know it still builds in csound6 branch. I'm curious why there are so many changes here. Will comment further when I have a chance to look at this further.

…

On Wed, Dec 27, 2023 at 8:05 PM werner mendizabal ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In CMakeLists.txt <#1797 (comment)>: > @@ -12,7 +12,9 @@ option(USE_VCPKG "Use VCPKG to download and manage dependencies" OFF) if (USE_VCPKG) # Detect correct triplet based on CMake env - if (WIN32) + if (CMAKE_SYSTEM_NAME STREQUAL "Emscripten") The variable EMSCRIPTEN was not available here. Maybe I'm missing something when configuring cmake? — Reply to this email directly, view it on GitHub <#1797 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMMA67HTOSTXP6ZDAZ75I3YLTAUDAVCNFSM6AAAAABA62NW3OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJXGU4DMNZRHE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[nonameentername]

The existing wasm build found in the wasm folder is using nix and wasi-sdk to create a wasm build.
There is some pre-processing that patches the source code with similar changes to the ones in this pull request before it compiles csound.

The changes in this pull request use vcpkg and emscripten compiler to create the wasm build.

[nonameentername]

Created a pull request to update vcpkg libflac microsoft/vcpkg#36080. Once merged the local libflac port can be removed.

[vlazzarini]

@kunstmusik how are we with this PR? Ready to merge?

[kunstmusik]

Took a look at this now and tried to reproduce the build locally on macOS. Installed emsdk and got through configuration and then tried to build:

stevenyi@stevens-MacBook-Pro cs7-prs % cmake --build build --config Release
[ 0%] Building C object CMakeFiles/csound.dir/Top/csound.c.o
/Users/stevenyi/work/csound/cs7-prs/Top/csound.c:1237:14: fatal error: 'execinfo.h' file not found
1237 | #include <execinfo.h>
| ^~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/csound.dir/Top/csound.c.o] Error 1
make[1]: *** [CMakeFiles/csound.dir/all] Error 2
make: *** [all] Error 2

Guessing this PR needs changes for macOS.

I was able to build our current nix-based WASM build from this branch though have not tested yet what was built.

Sidenote: @vlazzarini I saw we have a lot of preprocessor checks for NACL. I think these could be removed.

Also, there is a mixture now in our codebase between checking wasm and wasi. Haven't checked, but I wonder if we can normalize on one (i.e., will our nix-based build work if we just check for wasm ?).

cc: @hlolli

[kunstmusik]

Also to note, I saw a number of messages in the github actions build regarding data sizes for LONG and others. I seem to remember we patched some code back regarding sizes when we used Emscripten in CS6. Not sure what to make of this yet, but I wanted to note it here.

[vlazzarini]

Sidenote: @vlazzarini I saw we have a lot of preprocessor checks for NACL. I think these could be removed.

working on these now.