-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make hash table functions available to plugins #1706
Make hash table functions available to plugins #1706
Conversation
70e5368
to
f5c8602
Compare
f5c8602
to
6fe6b45
Compare
SUBR dummyfn_2[] needs to match the size of the initialisation in csound.c, which appears to have changed. |
Updated. I'll let someone else remove it later if they want. How do you feel about the new function names? I wasn't sure which nomenclature is right: |
I don't have much of a preference, just whatever looks more uniform with what's there already. |
let me know when you are ready for me to merge |
Ok, thanks. I'm developing this in parallel with an improved set of websocket opcodes, so I'm not 100% sure this PR has everything I need, yet. I'd like to get further along with those opcodes before marking this PR as ready. |
just to say, if the plugins have external dependencies, they need to go in the plugins repo, not here. |
Thanks, ya, I'm currently working from a fork of that repo, but I'm leaning towards it living in its own separate repo when it's done. |
that's even better |
I closed this PR because I'm having to do it on the Csound 6 branch instead of the Csound 7 branch, so it will work with Cabbage. |
why not both? It should not be too different. We don't want csound6 to diverge from develop. |
Exposes the internal hash table functions so I can use them in a new set of websocket opcodes I'm working on.