Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hash table functions available to plugins #1706

Conversation

docEdub
Copy link
Contributor

@docEdub docEdub commented Apr 21, 2023

Exposes the internal hash table functions so I can use them in a new set of websocket opcodes I'm working on.

@docEdub docEdub marked this pull request as draft April 22, 2023 06:09
@docEdub docEdub force-pushed the 220419-make-hash-table-functions-available-to-plugins branch from 70e5368 to f5c8602 Compare April 22, 2023 06:36
@docEdub docEdub force-pushed the 220419-make-hash-table-functions-available-to-plugins branch from f5c8602 to 6fe6b45 Compare April 22, 2023 07:19
@vlazzarini
Copy link
Member

SUBR dummyfn_2[] needs to match the size of the initialisation in csound.c, which appears to have changed.
Since we do not need ABI backwards compatibility with 6.x we can even remove this padding for now.

@docEdub
Copy link
Contributor Author

docEdub commented Apr 23, 2023

SUBR dummyfn_2[] needs to match the size of the initialisation in csound.c, which appears to have changed. Since we do not need ABI backwards compatibility with 6.x we can even remove this padding for now.

Updated. I'll let someone else remove it later if they want.

How do you feel about the new function names? I wasn't sure which nomenclature is right:
Prefixing with HashTable... like HashTableGet and HashTablePut, or prefixing with the verb like GetHashTableValue, GetHashTableKey, SetHashTableValue (or maybe PutHashTableValue?).

@vlazzarini
Copy link
Member

I don't have much of a preference, just whatever looks more uniform with what's there already.

@vlazzarini
Copy link
Member

let me know when you are ready for me to merge

@docEdub
Copy link
Contributor Author

docEdub commented Apr 27, 2023

let me know when you are ready for me to merge

Ok, thanks. I'm developing this in parallel with an improved set of websocket opcodes, so I'm not 100% sure this PR has everything I need, yet. I'd like to get further along with those opcodes before marking this PR as ready.

@vlazzarini
Copy link
Member

just to say, if the plugins have external dependencies, they need to go in the plugins repo, not here.

@docEdub
Copy link
Contributor Author

docEdub commented Apr 28, 2023

just to say, if the plugins have external dependencies, they need to go in the plugins repo, not here.

Thanks, ya, I'm currently working from a fork of that repo, but I'm leaning towards it living in its own separate repo when it's done.

@vlazzarini
Copy link
Member

that's even better

@docEdub docEdub closed this May 25, 2023
@docEdub docEdub deleted the 220419-make-hash-table-functions-available-to-plugins branch May 25, 2023 01:39
@docEdub
Copy link
Contributor Author

docEdub commented May 25, 2023

I closed this PR because I'm having to do it on the Csound 6 branch instead of the Csound 7 branch, so it will work with Cabbage.

@vlazzarini
Copy link
Member

vlazzarini commented May 25, 2023

why not both? It should not be too different. We don't want csound6 to diverge from develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants