Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer windows #386

Merged
merged 65 commits into from Mar 28, 2024
Merged

Installer windows #386

merged 65 commits into from Mar 28, 2024

Commits on Dec 19, 2023

  1. don't create coverage and logs directory on install 

    since we now write coverage and logs to the temp dir
    @karottenreibe
    karottenreibe committed Dec 19, 2023
    Copy the full SHA
    7576290 View commit details
    Browse the repository at this point in the history

  2. rename linux tests

    @karottenreibe
    karottenreibe committed Dec 19, 2023
    Copy the full SHA
    0638508 View commit details
    Browse the repository at this point in the history

  3. implement windows environment variable step

    @karottenreibe
    karottenreibe committed Dec 19, 2023
    Copy the full SHA
    ee68cc5 View commit details
    Browse the repository at this point in the history

  4. add test for WindowsRegistry and document code

    @karottenreibe
    karottenreibe committed Dec 19, 2023
    Copy the full SHA
    49dc75c View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. add Windows test and refactor existing tests

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    43896e5 View commit details
    Browse the repository at this point in the history

  2. add windows build

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    fe25c08 View commit details
    Browse the repository at this point in the history

  3. fix TS findings

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    6ec4999 View commit details
    Browse the repository at this point in the history

  4. fix linux tests

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    ed160d4 View commit details
    Browse the repository at this point in the history

  5. advise Windows users to restart after installation

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    7188cbf View commit details
    Browse the repository at this point in the history

  6. rename windows build step to "Test" 

    since it is only there to run the tests on Windows
    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    02ee449 View commit details
    Browse the repository at this point in the history

  7. fix warning and improve error message

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    3f329e9 View commit details
    Browse the repository at this point in the history

  8. disable problematic test on Windows

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    2085016 View commit details
    Browse the repository at this point in the history

  9. provide nice asserts for error reporter

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    db232f0 View commit details
    Browse the repository at this point in the history

  10. add utility to mark directories as not writable during tests

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    6c93f90 View commit details
    Browse the repository at this point in the history

  11. convert to jlink build 

    had to convert the installer to a Java 17 module and replace com.teamscale dependencies with Apache commons
    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    d3e5f3a View commit details
    Browse the repository at this point in the history

  12. include jlink installer in agent dist

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    d6457c7 View commit details
    Browse the repository at this point in the history

  13. remove incorrect test assertion

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    b0acde9 View commit details
    Browse the repository at this point in the history

  14. fix TS finding

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    3d83554 View commit details
    Browse the repository at this point in the history

  15. use normal java instead of GraalVM

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    ef63bca View commit details
    Browse the repository at this point in the history

  16. update okhttp

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    0c4fcb4 View commit details
    Browse the repository at this point in the history

  17. use jdk 17 also in docker build

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    db7c155 View commit details
    Browse the repository at this point in the history

  18. fix docker build 

    was missing xargs in the newer openjdk image
    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    1e463ae View commit details
    Browse the repository at this point in the history

  19. add platform to coverage upload message

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    2a9713a View commit details
    Browse the repository at this point in the history

  20. use java 17 in build

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    efa88e0 View commit details
    Browse the repository at this point in the history

  21. fix incorrect test enablement

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    c0a2ca0 View commit details
    Browse the repository at this point in the history

  22. fix quoting jvm options

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    b11e903 View commit details
    Browse the repository at this point in the history

  23. do not strip debug info so we get line numbers in stack traces

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    c006d38 View commit details
    Browse the repository at this point in the history

  24. try fixing windows tests that depend on read-only file

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    ef491d0 View commit details
    Browse the repository at this point in the history

  25. prevent verbose error messages

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    f0b312b View commit details
    Browse the repository at this point in the history

  26. add tests for common Teamscale communication errors

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    fcdf2b7 View commit details
    Browse the repository at this point in the history

  27. don't log useless stack traces of fatal error causes

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    668cc15 View commit details
    Browse the repository at this point in the history

  28. move utilities to their own package

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    201d33f View commit details
    Browse the repository at this point in the history

  29. fix broken test

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    5bc8e56 View commit details
    Browse the repository at this point in the history

  30. another attempt at making a directory read-only on Windows

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    3ea0189 View commit details
    Browse the repository at this point in the history

  31. move test to correct package

    @karottenreibe
    karottenreibe committed Dec 20, 2023
    Copy the full SHA
    a98463c View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. try fixing tests

    @karottenreibe
    karottenreibe committed Dec 21, 2023
    Copy the full SHA
    74a2cd9 View commit details
    Browse the repository at this point in the history

  2. simplify marking windows files as read-only

    @karottenreibe
    karottenreibe committed Dec 21, 2023
    Copy the full SHA
    6917bff View commit details
    Browse the repository at this point in the history

  3. fix test on Windows

    @karottenreibe
    karottenreibe committed Dec 21, 2023
    Copy the full SHA
    fa92728 View commit details
    Browse the repository at this point in the history

  4. fix test on Linux

    @karottenreibe
    karottenreibe committed Dec 21, 2023
    Copy the full SHA
    f7830e0 View commit details
    Browse the repository at this point in the history

  5. another attempt at fixing windows permissions in tests

    @karottenreibe
    karottenreibe committed Dec 21, 2023
    Copy the full SHA
    6cf1cd3 View commit details
    Browse the repository at this point in the history

  6. fix maven build on windows

    @karottenreibe
    karottenreibe committed Dec 21, 2023
    Copy the full SHA
    0beb125 View commit details
    Browse the repository at this point in the history

  7. add missing dependency to maven builds 

    build failed when running :teamscale-maven-plugin:build off a fresh git checkout with an empty maven cache
    @karottenreibe
    karottenreibe committed Dec 21, 2023
    Copy the full SHA
    1cc4d73 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. add more helpful error messages to assert

    @karottenreibe
    karottenreibe committed Dec 22, 2023
    Copy the full SHA
    aae99e0 View commit details
    Browse the repository at this point in the history

  2. fix test failure on Windows caused by wrong path separator

    @karottenreibe
    karottenreibe committed Dec 22, 2023
    Copy the full SHA
    bc81721 View commit details
    Browse the repository at this point in the history

  3. fix more incorrect invocations of mvnw.cmd

    @karottenreibe
    karottenreibe committed Dec 22, 2023
    Copy the full SHA
    f8cefd4 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. fix path to installer.bat

    @karottenreibe
    karottenreibe committed Jan 31, 2024
    Copy the full SHA
    6b27cd6 View commit details
    Browse the repository at this point in the history

  2. also build windows installer 

    jlink by default builds only the current platform
    @karottenreibe
    karottenreibe committed Jan 31, 2024
    Copy the full SHA
    8c87488 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. rename scripts so they match usage help

    @karottenreibe
    karottenreibe committed Feb 2, 2024
    Copy the full SHA
    ea3ce81 View commit details
    Browse the repository at this point in the history

  2. find source directory from jlink jvm 

    needed to change the logic because with JLink, the Installer class's code location is `/modules/something`, which is not a real path

Using the jlink java.home instead, since this is guaranteed to be at a fixed place within the source directory
    @karottenreibe
    karottenreibe committed Feb 2, 2024
    Copy the full SHA
    974d64f View commit details
    Browse the repository at this point in the history

  3. fix installation directory on windows

    @karottenreibe
    karottenreibe committed Feb 2, 2024
    Copy the full SHA
    7d10448 View commit details
    Browse the repository at this point in the history

  4. ask user to manually delete install directory on windows 

    because while the uninstaller is running, we can't delete the directory it is in. That only works on Linux
    @karottenreibe
    karottenreibe committed Feb 2, 2024
    Copy the full SHA
    1c3b077 View commit details
    Browse the repository at this point in the history

  5. make sure the profiler is not profiling the uninstaller 

    this may cause problems when we try to delete files etc.
    @karottenreibe
    karottenreibe committed Feb 2, 2024
    Copy the full SHA
    10516c8 View commit details
    Browse the repository at this point in the history

  6. always advise to restart computer after uninstallation

    @karottenreibe
    karottenreibe committed Feb 2, 2024
    Copy the full SHA
    b7a1292 View commit details
    Browse the repository at this point in the history

  7. fix warnings

    @karottenreibe
    karottenreibe committed Feb 2, 2024
    Copy the full SHA
    ee38f2c View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into installer_windows

    @karottenreibe
    karottenreibe committed Feb 2, 2024
    Copy the full SHA
    b7a0237 View commit details
    Browse the repository at this point in the history

  9. fix tests since on Windows we don't remove the install directory

    @karottenreibe
    karottenreibe committed Feb 2, 2024
    Copy the full SHA
    777bce5 View commit details
    Browse the repository at this point in the history

  10. fix warnings

    @karottenreibe
    karottenreibe committed Feb 2, 2024
    Copy the full SHA
    9706a93 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. export doesn't work in sh 

    only in bash
    @karottenreibe
    karottenreibe committed Feb 7, 2024
    Copy the full SHA
    94c15ac View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Merge remote-tracking branch 'origin/master' into installer_windows

    @karottenreibe
    karottenreibe committed Mar 12, 2024
    Copy the full SHA
    407b5b1 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. rework

    @karottenreibe
    karottenreibe committed Mar 28, 2024
    Copy the full SHA
    3e5bee6 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into installer_windows

    @karottenreibe
    karottenreibe committed Mar 28, 2024
    Copy the full SHA
    ca6d7b9 View commit details
    Browse the repository at this point in the history

  3. remove unnecessary dependsOn calls

    @karottenreibe
    karottenreibe committed Mar 28, 2024
    Copy the full SHA
    eaffc8f View commit details
    Browse the repository at this point in the history

  4. change formatter settings 

    do not align multi-line stuff - that breaks the GitHub diff viewer
    @karottenreibe
    karottenreibe committed Mar 28, 2024
    Copy the full SHA
    eaa17c7 View commit details
    Browse the repository at this point in the history

  5. reuse systemtest port convention

    @karottenreibe
    karottenreibe committed Mar 28, 2024
    Copy the full SHA
    3342917 View commit details
    Browse the repository at this point in the history

  6. remove system test clone

    @karottenreibe
    karottenreibe committed Mar 28, 2024
    Copy the full SHA
    9c98428 View commit details
    Browse the repository at this point in the history