Installer windows #386
Merged
Installer windows #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we now write coverage and logs to the temp dir
karottenreibe
changed the base branch from
master
to
ts/33237_profiler_config_teamscale
since it is only there to run the tests on Windows
had to convert the installer to a Java 17 module and replace com.teamscale dependencies with Apache commons
was missing xargs in the newer openjdk image
build failed when running :teamscale-maven-plugin:build off a fresh git checkout with an empty maven cache
1 task
jlink by default builds only the current platform
needed to change the logic because with JLink, the Installer class's code location is `/modules/something`, which is not a real path Using the jlink java.home instead, since this is guaranteed to be at a fixed place within the source directory
because while the uninstaller is running, we can't delete the directory it is in. That only works on Linux
this may cause problems when we try to delete files etc.
only in bash
karottenreibe
force-pushed
the
installer_windows
branch
from
36d30af
to
407b5b1
Compare
DreierF
requested changes
Mar 21, 2024
installer/src/main/java/com/teamscale/profiler/installer/steps/IStep.java
Outdated
Show resolved
Hide resolved
installer/src/test/java/com/teamscale/profiler/installer/AllPlatformsInstallerTest.java
Outdated
Show resolved
Hide resolved
installer/src/test/java/com/teamscale/profiler/installer/LinuxInstallerTest.java
Outdated
Show resolved
Hide resolved
system-tests/tia-maven/src/test/java/com/teamscale/tia/TiaMavenMultipleJobsTest.java
Outdated
Show resolved
Hide resolved
do not align multi-line stuff - that breaks the GitHub diff viewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue TS-36948
Please respect the vote of the Teamscale bot or flag irrelevant findings as tolerated or false positives. If you feel that the Teamscale config needs adjustment, please state so in a comment and discuss this with your reviewer.