Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in GetRandFrames... #167

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

sylviaschroeder
Copy link
Collaborator

when using a specific experiment to get target image (targetImage not empty)

This is resolving issue #166

I tested the new code when targetImage is not empty. Please, have a look for when targetImage is empty. However, I based the new code primarily on the old code that existed for the case when targetImage is empty.

@carsen-stringer
Copy link
Collaborator

Sorry but can you please double check it works with targetImage empty too? It looks good but I'd rather play it safe because that's the setting most people will use.

xigumalu added 3 commits May 17, 2019 13:04
…ames in tiff were not a mupltiple of number of planes)
…ic experiment used for target image construction (default case)
@sylviaschroeder
Copy link
Collaborator Author

I tested the code now for use with targetImage empty. It works as expected.

@marius10p
Copy link
Collaborator

I am going to pull this in... if it breaks something, someone say something?

@ondra6
Copy link

ondra6 commented Nov 7, 2019

Dear colleagues, I just installed and troubleshot the beginning with the matlab version of suite2p.
I don't know where to write, but I think I identified a bug in build_ops3.m
On line 31 it says
ffile = dir(fullfile(ops.RootDir, ops.SubDirs{j}, '.tif'));
I think that there should be square brackets in the fullfile function.
ffile = dir([fullfile(ops.RootDir, ops.SubDirs{j}, '
.tif')]);

This was what helped me to go through the pipeline.

I would also like to express the deepest gratitude for your software package. It is awesome!

@marius10p
Copy link
Collaborator

Thanks! @xigumalu can you please check this and if it's right I can merge the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants