Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RangeSliderSkin as fix for #1521 #1522

Merged
merged 2 commits into from Nov 6, 2023

Conversation

james-d
Copy link
Contributor

@james-d james-d commented Oct 6, 2023

Fixes jumping of range bar when dragging range bar in vertical range slider.

Fixes #1099

Fixes jumping of range bar when dragging range bar in vertical range slider.
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Hi james-d,

Welcome to ControlsFX and thank you for taking time to contribute to this project.

We do not recognise you as a contributor. Can you please sign ControlsFX Individual Contributor Agreement: https://cla.controlsfx.org ?

@github-actions github-actions bot added the CLA label Oct 6, 2023
@james-d
Copy link
Contributor Author

james-d commented Oct 6, 2023

I think the first time I did this I had the incorrect GitHub user name. That should be rectified.

@james-d james-d changed the title Update RangeSlliderSkin as fix for #1521 Update RangeSliderSkin as fix for #1521 Oct 8, 2023
@Siedlerchr
Copy link
Collaborator

Tested it on my Macbook M1 an could reproduce the original issue and also confirm the fix

Copy link
Collaborator

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could confirm the fix on macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RangeSlider stutters when the track is dragged in vertical orientation.
3 participants