Fixes jumping of range bar when dragging range bar in vertical range …

…slider (#1522)
controlsfx · Nov 6, 2023 · 14cd145 · 14cd145
1 parent dc172e7
commit 14cd145
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/controlsfx/src/main/java/impl/org/controlsfx/skin/RangeSliderSkin.java b/controlsfx/src/main/java/impl/org/controlsfx/skin/RangeSliderSkin.java
@@ -83,12 +83,21 @@ public RangeSliderSkin(final RangeSlider rangeSlider) {
         initRangeBar();
         registerChangeListener(rangeSlider.lowValueProperty(), e -> {
             positionLowThumb();
-            rangeBar.resizeRelocate(rangeStart, rangeBar.getLayoutY(), 
-            rangeEnd - rangeStart, rangeBar.getHeight());
+            if (isHorizontal()) {
+                rangeBar.resizeRelocate(rangeStart, rangeBar.getLayoutY(),
+                        rangeEnd - rangeStart, rangeBar.getHeight());
+            } else {
+                rangeBar.resize(rangeBar.getWidth(), rangeEnd - rangeStart);
+            }
         });
         registerChangeListener(rangeSlider.highValueProperty(), e -> {
             positionHighThumb();
-            rangeBar.resize(rangeEnd-rangeStart, rangeBar.getHeight());
+            if (isHorizontal()) {
+                rangeBar.resize(rangeEnd - rangeStart, rangeBar.getHeight());
+            } else {
+                rangeBar.resizeRelocate(rangeBar.getLayoutX(), rangeStart,
+                        rangeBar.getWidth(), rangeEnd - rangeStart);
+            }
         });
         registerChangeListener(rangeSlider.minProperty(), e -> {
             if (showTickMarks && tickLine != null) {
@@ -402,7 +411,7 @@ private void positionHighThumb() {
         double y = orientation ? lowThumb.getLayoutY() : (getSkinnable().getInsets().getTop() + trackLength) - trackLength * ((slider.getHighValue() - slider.getMin()) / (getMaxMinusMinNoZero()));
         highThumb.setLayoutX(x);
         highThumb.setLayoutY(y);
-        if (orientation) rangeEnd = x; else rangeStart = y + thumbWidth;
+        if (orientation) rangeEnd = x; else rangeStart = y + thumbHeight;
     }
 
     @Override protected void layoutChildren(final double x, final double y,