Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added schema id check to the JsonSchemaResolver #2136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added schema id check to the JsonSchemaResolver #2136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Confluent.SchemaRegistry.Serdes.Json/JsonSchemaResolver.cs
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@
using NJsonSchema;
using NJsonSchema.Generation;
using Newtonsoft.Json.Linq;

using Confluent.Kafka;

namespace Confluent.SchemaRegistry.Serdes
{
Expand All @@ -45,7 +45,7 @@ private void CreateSchemaDictUtil(Schema root)
{
string root_str = root.SchemaString;
JObject schema = JObject.Parse(root_str);
string schemaId = (string)schema["$id"];
string schemaId = (string)schema["$id"] ?? throw new Exception("Provided schema does not have $id property.");
if (!dictSchemaNameToSchema.ContainsKey(schemaId))
this.dictSchemaNameToSchema.Add(schemaId, root);

Expand Down