Added schema id check to the JsonSchemaResolver #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gokerakc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: $id property is not required for JSON schemas but in the JsonSchemaResolver class we need to use the schema id value and there is no null check in place for it.
Current behavior:
JsonSchemaResolverthrows the following error when the provided schema does not have a schema id;System.ArgumentNullException: 'Value cannot be null. Arg_ParamName_Name'(error reason is not clear)Desired behavior:
JsonSchemaResolverthrows the following exception when the schema id is null;System.Exception: 'Provided schema does not have $id property.'If you have a different solution for this issue or any suggestion for the exception message please let me know.