Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue with newline on conda run #13841

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixing issue with newline on conda run #13841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36fbf06
Added documentation for custom_multichannel
sohamvakani Apr 24, 2024
32ae070
Added end='' to print in execute for main cli in conda run
sohamvakani Apr 24, 2024
c8b7280
Added new file for error fix for conda new line
sohamvakani Apr 24, 2024
7b8cc58
Removed old changes from documentation PR
sohamvakani Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions conda/cli/main_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,9 @@ def execute(args: Namespace, parser: ArgumentParser) -> int:
# display stdout/stderr if it was captured
if not args.no_capture_output:
if response.stdout:
print(response.stdout, file=sys.stdout)
print(response.stdout, file=sys.stdout,end='')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print(response.stdout, file=sys.stdout,end='')
print(response.stdout, file=sys.stdout, end="")

Addresses pre-commit check failure.

if response.stderr:
print(response.stderr, file=sys.stderr)
print(response.stderr, file=sys.stderr,end='')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print(response.stderr, file=sys.stderr,end='')
print(response.stderr, file=sys.stderr, end="")

Addresses pre-commit check failure.


# log error
if response.rc != 0:
Expand Down
19 changes: 19 additions & 0 deletions news/11763-newline-condarun-error
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Enhancements

* <news item>

### Bug fixes

* Fixed newline error on conda run #11763
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fixed newline error on conda run #11763
* Fixed newline error for conda run (#11763)


### Deprecations

* <news item>

### Docs

* <news item>

### Other

* <news item>
6 changes: 6 additions & 0 deletions test_env.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
name: test_env
channels:
- include-me
- defaults
- conda-forge
prefix: /Users/sohamvakani/Documents/EECE3093_SoftwareEngineering/conda-EECE3093/devenv/Darwin/x86_64/envs/devenv-3.10-c/envs/test_env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this was something created to test this locally? Please remove this file.