Fixing issue with newline on conda run #13841
Conversation
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @sohamvakani. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#921), and ping the bot to refresh the PR. |
|
@conda-bot check |
conda-bot
added
the
cla-signed
There was a problem hiding this comment.
Thanks for this pull request. Please see my requested changes.
Also, before we consider this ready for approval, we will need to see some new tests to assert that your changes actually solve the problem. These tests can be placed in tests/cli/test_main_run.py.
Please let us know if you have any questions.
| - include-me | ||
| - defaults | ||
| - conda-forge | ||
| prefix: /Users/sohamvakani/Documents/EECE3093_SoftwareEngineering/conda-EECE3093/devenv/Darwin/x86_64/envs/devenv-3.10-c/envs/test_env |
There was a problem hiding this comment.
I'm guessing this was something created to test this locally? Please remove this file.
|
|
||
| ### Bug fixes | ||
|
|
||
| * Fixed newline error on conda run #11763 |
There was a problem hiding this comment.
| * Fixed newline error on conda run #11763 | |
| * Fixed newline error for conda run (#11763) |
| @@ -115,9 +115,9 @@ def execute(args: Namespace, parser: ArgumentParser) -> int: | |||
| # display stdout/stderr if it was captured | |||
| if not args.no_capture_output: | |||
| if response.stdout: | |||
| print(response.stdout, file=sys.stdout) | |||
| print(response.stdout, file=sys.stdout,end='') | |||
There was a problem hiding this comment.
| print(response.stdout, file=sys.stdout,end='') | |
| print(response.stdout, file=sys.stdout, end="") |
Addresses pre-commit check failure.
| if response.stderr: | ||
| print(response.stderr, file=sys.stderr) | ||
| print(response.stderr, file=sys.stderr,end='') |
There was a problem hiding this comment.
| print(response.stderr, file=sys.stderr,end='') | |
| print(response.stderr, file=sys.stderr, end="") |
Addresses pre-commit check failure.
Description
Fixing newline conda error from issue #11763
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?