Amend test suite for compatibility with libmamba v2 #13784
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #13784 will not alter performanceComparing Summary
|
9 tasks
jaimergp
commented
Apr 11, 2024
| @@ -707,6 +708,9 @@ def test_nonexistent_deps(self, env): | |||
| "test::pip-1.3.1-py33_1", | |||
| } | |||
|
|
|||
| # Add 1s to make sure the new repodata.jsons have different mod times | |||
There was a problem hiding this comment.
Suggested change
| # Add 1s to make sure the new repodata.jsons have different mod times | |
| # Add 1s to make sure the new repodata.jsons have different mod times | |
| # To be fixed by https://github.com/conda/conda/issues/13783 |
jaimergp
commented
Apr 11, 2024
| # LIBMAMBA ADJUSTMENT | ||
| # libmamba doesn't remove xz in this solve | ||
| *(() if context.solver == "libmamba" else ("channel-2::xz-5.2.3-0",)), | ||
| "channel-2::xz-5.2.3-0", |
There was a problem hiding this comment.
v2 fixed this solver difference. We can still bring it back with this change, though.
jaimergp
commented
Apr 11, 2024
| @@ -124,7 +124,7 @@ def bash_unsupported() -> str | None: | |||
|
|
|||
|
|
|||
| skip_unsupported_bash = pytest.mark.skipif( | |||
| bash_unsupported(), | |||
| bool(bash_unsupported()), | |||
There was a problem hiding this comment.
I think a recent pytest release got stricter about the types here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Companion PR for conda/conda-libmamba-solver#457.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?