Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for libmamba v2 (WIP) #457

Draft
wants to merge 76 commits into
base: main
Choose a base branch
from
Draft

Refactor for libmamba v2 (WIP) #457

wants to merge 76 commits into from

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Mar 26, 2024

Description

A WIP branch of the refactors enabled by libmamba v2. Supersedes #414.

Progress:

  • Refactor index helpers
  • Refactor repoquery
  • Refactor solver
  • Refactor conflict reports
  • Pass all tests
  • Polish and clean up

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 26, 2024
@jaimergp
Copy link
Contributor Author

pre-commit.ci autofix

@jaimergp
Copy link
Contributor Author

Well, well, we are down to one failing test in Unix:

tests/core/test_solve.py::test_channel_priority_churn_minimized[libmamba]

Everything else is passing with the help of conda/conda#13784.

Windows has a couple of extra issues but nothing major. To be investigated.

@jaimergp
Copy link
Contributor Author

jaimergp commented Apr 10, 2024

I looked into the Windows errors and while I can reproduce the pytest errors, equivalent exercises without pytest do pass locally 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

None yet

2 participants