New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging #13735
base: main
Are you sure you want to change the base?
Improve logging #13735
Conversation
CodSpeed Performance ReportMerging #13735 will improve performances by 14.48%Comparing Summary
Benchmarks breakdown
|
We should adjust the benchmark to ignore jlap test setup/teardown. We should cache or save a local dummy ssl certificate used for that test https server. |
Co-authored-by: Jannis Leidel <jannis@leidel.info>
I updated the documentation part of this PR to address @jezdez' comments. I think there is still value in the actual code changes; if you prefer not to add the deep dive, we can just remove that. |
conda/gateways/logging.py
Outdated
# root gets level ERROR | ||
# 'conda' gets level WARN and does not propagate to root. | ||
initialize_root_logger() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should remove initialize_root_logger
, AFAIK this is the source of logging issues in downstream projects (e.g., conda/conda-build#5275 (comment)).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have simply removed initialize_root_logger
. I think this is justified in light of the fact that the whole logging hierarchy starts with an additional "root", conda
, which is configured separately.
pre-commit.ci autofix |
Description
Fixes #13541
Checklist - did you ...
news
directory (using the template) for the next release's release notes?