-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save certificate for use in tests #13750
Conversation
you can also update the test to isolate the code to benchmark versus the setup/teardown: @pytest.mark.benchmark
def test(benchmark):
# setup
@benchmark
def _():
# code to benchmark
# teardown |
CodSpeed Performance ReportMerging #13750 will degrade performances by 66.66%Comparing Summary
Benchmarks breakdown
|
Sounds good, looking at those functions that happened to be tagged as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't we just depend on Werkzeug in the tests? Aren't we already using flask in the tests?
|
||
### Other | ||
|
||
* Use static ssl certificate in test suite to save time (#13750) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Use static ssl certificate in test suite to save time (#13750) | |
* Use static ssl certificate in test suite to save time. (#13750) |
It looks like this doesn't speed up the tests as hoped. |
Description
An attempt to speed up the tests by not creating a new certificate all the time.
To address codspeed regressions in #13735
Checklist - did you ...
news
directory (using the template) for the next release's release notes?