Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pycatch22 specifier #118

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

fkiraly
Copy link
Contributor

@fkiraly fkiraly commented Apr 16, 2024

This fixes the invalid specifier for pycatch22 in the "all extras" release.

@fkiraly fkiraly added the bug Something isn't working label Apr 16, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@fkiraly
Copy link
Contributor Author

fkiraly commented Apr 16, 2024

@conda-forge/core, I think this issue might be of interest.
Apologies if this summon is based on misdiagnosis.

An sktime user, @tm-slavik57, noticed that the sktime-all-extras dep set did not install due to a stray comma in the run_constrained section of the recipe, and apparently only on windows - on other OS it only raises a warning.

The CI of 0.28.0 all passed, including on windows.

@tm-slavik57 opened issues on:

@fkiraly
Copy link
Contributor Author

fkiraly commented Apr 16, 2024

FYI @yarnabrina

@yarnabrina
Copy link
Contributor

Should we merge and see if this fixes the issue on windows? I'm not familiar enough with conda forge to know if it can be tested without merge.

(By test I meant installing sktime on windows manually and checking if pycatch22 is being installed or not)

@fkiraly
Copy link
Contributor Author

fkiraly commented Apr 16, 2024

yes, let's - what I don't know if this fixes the issue with 0.28.0 on conda.

If it were pypi, it wouldn't - generally, versions can not be updated on pypi, only pulled - for security reasons (otherwise malicious actors could to targeted switches of versions)

@yarnabrina yarnabrina merged commit beaf1be into conda-forge:main Apr 16, 2024
22 checks passed
@tm-slavik57
Copy link

I patched conda-forge with this PR: conda-forge/conda-forge-repodata-patches-feedstock#706
Now installing 0.28.0 works fine.
So together with this PR it is now consistent with the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants