Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sktime constraint on pycatch22 #706

Merged

Conversation

tm-slavik57
Copy link
Contributor

@tm-slavik57 tm-slavik57 commented Apr 16, 2024

The pycatch22 constraint of sktime has a redundant comma at the end which breaks conda installations.

Relates to these:

Output of the show_diff.py script I ran locally:

$ python show_diff.py 
================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
osx-arm64
osx-arm64::sktime-0.28.0-py38h10201cd_0.conda
osx-arm64::sktime-0.28.0-py310hbe9552e_0.conda
osx-arm64::sktime-0.28.0-py39h2804cbe_0.conda
osx-arm64::sktime-0.28.0-py311h267d04e_0.conda
-    "pycatch22 >=0.4,<0.4.4,",
+    "pycatch22 >=0.4,<0.4.4",
================================================================================
================================================================================
linux-ppc64le
================================================================================
================================================================================
linux-aarch64
linux-aarch64::sktime-0.28.0-py310h4c7bcd0_0.conda
linux-aarch64::sktime-0.28.0-py38he3eb160_0.conda
linux-aarch64::sktime-0.28.0-py39h4420490_0.conda
linux-aarch64::sktime-0.28.0-py311hec3470c_0.conda
-    "pycatch22 >=0.4,<0.4.4,",
+    "pycatch22 >=0.4,<0.4.4",
================================================================================
================================================================================
noarch
================================================================================
================================================================================
win-64
win-64::sktime-0.28.0-py39hcbf5309_0.conda
win-64::sktime-0.28.0-py311h1ea47a8_0.conda
win-64::sktime-0.28.0-py310h5588dad_0.conda
win-64::sktime-0.28.0-py38haa244fe_0.conda
-    "pycatch22 >=0.4,<0.4.4,",
+    "pycatch22 >=0.4,<0.4.4",
================================================================================
================================================================================
osx-64
osx-64::sktime-0.28.0-py39h6e9494a_0.conda
osx-64::sktime-0.28.0-py311h6eed73b_0.conda
osx-64::sktime-0.28.0-py38h50d1736_0.conda
osx-64::sktime-0.28.0-py310h2ec42d9_0.conda
-    "pycatch22 >=0.4,<0.4.4,",
+    "pycatch22 >=0.4,<0.4.4",
================================================================================
================================================================================
linux-64
linux-64::sktime-0.28.0-py39hf3d152e_0.conda
linux-64::sktime-0.28.0-py38h578d9bd_0.conda
linux-64::sktime-0.28.0-py311h38be061_0.conda
linux-64::sktime-0.28.0-py310hff52083_0.conda
-    "pycatch22 >=0.4,<0.4.4,",
+    "pycatch22 >=0.4,<0.4.4",

The dependency has a redundant comma in the end which breaks conda installations.
@tm-slavik57 tm-slavik57 requested a review from a team as a code owner April 16, 2024 12:14
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@tm-slavik57
Copy link
Contributor Author

@fkiraly
This PR patches this bug: sktime/sktime#6304

@tm-slavik57 tm-slavik57 changed the title Fix sktime dependency on pycatch22 Fix sktime constraint on pycatch22 Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants