New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pull_request_template.md #4518
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| - [ ] Link to pivotal/JIRA issue | ||
rickreyhsig marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - [ ] What was done? | ||
| - Explain the implementation goals being solved or the feature with the reviewer in mind | ||
| - Mention any relevant issues or technical gotchas | ||
rickreyhsig marked this conversation as resolved.
Show resolved
Hide resolved
rickreyhsig marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - Alternatives considered | ||
| - [ ] How to test? | ||
| - Describe the testing approach taken to verify the changes, including: | ||
| - Unit/integration/manual tests | ||
| - Test data used | ||
| - Specify any relevant testing environments used (e.g., development, staging, demo, Heroku). | ||
| - Risk Assessment | ||
| - Risks or side effects associated with the changes and how they were mitigated. | ||
| - Highlight areas that may need extra attention during code review or testing. | ||
| - Paste SQL queries or output where relevant | ||
| - [ ] Screenshots (for visual change) | ||
| - Before | After | ||
rickreyhsig marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting these to be headers (like
##) instead of checkboxes, and then the person filling this our just adds their thoughts under it, what do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I suppose headers make a little more sense.