New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pull_request_template.md #4518
Conversation
New pull request template suggestion
Heroku app: https://gyr-review-app-4518-6592683c3518.herokuapp.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left something to consider changing
docs/pull_request_template.md
Outdated
@@ -0,0 +1,17 @@ | |||
- [ ] Link to pivotal/JIRA issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting these to be headers (like ##
) instead of checkboxes, and then the person filling this our just adds their thoughts under it, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I suppose headers make a little more sense.
New pull request template suggestion for vita/fyst repos
https://github.com/codeforamerica/vita-min/blob/cf9391ee421dfdbb90402d10e4ec2193547258d6/docs/pull_request_template.md