Validate dob #186989077 #4463
Closed
Validate dob #186989077 #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-warning-#186829970
|
Heroku app: https://gyr-review-app-4463-ac44ff4d2273.herokuapp.com/ |
mpidcock
reviewed
Apr 12, 2024
| </div> | ||
| <% elsif ff.object.ctc_qualifying %> | ||
| <div class="form-group"> | ||
| <%= ff.warning_for_date("#{ff.object_name}[dob_year]", MultiTenantService.statefile.end_of_current_tax_year.years_ago(17), nil, nil, t(".dependent_dob_under_17_warning")) %> |
There was a problem hiding this comment.
Consider extracting MultiTenantService.statefile.end_of_current_tax_year so that here and @sixty_five_years_ago can both use it and not be inconsistent about extracting a variable for one age and not the other.
|
closing for now. will bring back if still relevant for FYST 2025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning for cases where return indicates that the user was over 65 but the DOB was under 65:
Warning for cases where return indicates that the user was under 65 but the DOB was over 65:
