New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependent birth year warning #186829970 #4458
Open
tofarr
wants to merge
41
commits into
main
Choose a base branch
from
dependent-birth-year-warning-#186829970
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-warning-#186829970
Heroku app: https://gyr-review-app-4458-9fb9fbc0a582.herokuapp.com/ |
mpidcock
reviewed
Apr 12, 2024
</div> | ||
<% elsif ff.object.ctc_qualifying %> | ||
<div class="form-group"> | ||
<%= ff.warning_for_date(ff.object_name, MultiTenantService.statefile.end_of_current_tax_year.years_ago(17), nil, t(".dependent_dob_under_17_warning")) %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment in #4463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I follow the general pattern established in the NY County page for this (albeit with a new component for date field warnings).
When putting in a DOB for a dependent, you now get a warning if they have
EligibleForChildTaxCreditInd
and the value you put in is >= 2006-12-31If the intake is NY (Not AZ) and the dependent appears on Schedule EIC, check year of birth against year entered and show this message: