testutils/docker: remove use of docker gotag
#123318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
optimize-docker-build
branch
2 times, most recently
from
6fae6e8
to
784c83b
Compare
The `docker` tag here doesn't seem to serve any purpose besides preventing the test from being run by `go test ./...`. Instead, we simply skip the test if it's not built with Bazel. Closes cockroachdb#123265. Epic: None Release note: None
rickystewart
force-pushed
the
optimize-docker-build
branch
from
784c83b
to
8c51559
Compare
rickystewart
added
the
backport-24.1.x
rail
approved these changes
Apr 30, 2024
|
bors r=rail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dockertag here doesn't seem to serve any purpose besides preventing the test from being run bygo test ./.... Instead, we simply skip the test if it's not built with Bazel.Closes #123265.
Epic: None
Release note: None