testutils/docker: remove use of docker gotag

The `docker` tag here doesn't seem to serve any purpose besides
preventing the test from being run by `go test ./...`. Instead, we
simply skip the test if it's not built with Bazel.

Closes #123265.

Epic: None
Release note: None

pkg/testutils/docker/BUILD.bazel

@@ -1,20 +1,19 @@
 load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
 
-# keep
 go_test(
     name = "docker_test",
     srcs = ["single_node_docker_test.go"],
     data = glob(["testdata/**"]) + [
         "//pkg/testutils/docker:testdata",
         "//pkg/testutils/docker/docker-fsnotify",
     ],
-    gotags = ["docker"],
     tags = [
         "integration",
         "no-remote-exec",
     ],
     deps = [
-        "//pkg/util/ctxlog",
+        "//pkg/build/bazel",
+        "//pkg/testutils/skip",
         "//pkg/util/log",
         "//pkg/util/timeutil",
         "@com_github_cockroachdb_errors//:errors",

pkg/testutils/docker/single_node_docker_test.go

@@ -8,9 +8,6 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
-//go:build docker
-// +build docker
-
 package docker
 
 import (
@@ -21,12 +18,13 @@ import (
 	"io"
 	"math"
 	"os"
-	"path/filepath"
 	"strconv"
 	"strings"
 	"testing"
 	"time"
 
+	"github.com/cockroachdb/cockroach/pkg/build/bazel"
+	"github.com/cockroachdb/cockroach/pkg/testutils/skip"
 	"github.com/cockroachdb/cockroach/pkg/util/log"
 	"github.com/cockroachdb/cockroach/pkg/util/timeutil"
 	"github.com/cockroachdb/errors"
@@ -75,7 +73,14 @@ func TestSingleNodeDocker(t *testing.T) {
 		t.Fatal(errors.NewAssertionErrorWithWrappedErrf(err, "cannot get pwd"))
 	}
 
-	fsnotifyBinPath := filepath.Join(pwd, "docker-fsnotify/docker-fsnotify-bin")
+	if !bazel.BuiltWithBazel() {
+		skip.IgnoreLint(t)
+	}
+
+	fsnotifyBinPath, err := bazel.Runfile("pkg/testutils/docker/docker-fsnotify/docker-fsnotify-bin")
+	if err != nil {
+		t.Fatal(err)
+	}
 
 	var dockerTests = []singleNodeDockerTest{
 		{

pkg/testutils/lint/lint_test.go

@@ -2010,6 +2010,8 @@ func TestLint(t *testing.T) {
 			// times and merging the results: https://staticcheck.io/docs/running-staticcheck/cli/build-tags/
 			// This is more trouble than it's worth right now.
 			stream.GrepNot(`pkg/cmd/mirror/go/mirror.go`),
+			// As above, the bazel build tag has an impact here.
+			stream.GrepNot(`pkg/testutils/docker/single_node_docker_test.go`),
 		}
 		for analyzerName, config := range nogoConfig {
 			if !staticcheckCheckNameRe.MatchString(analyzerName) {