Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2: cli: include cpu profiles into debug.zip #123243

Merged
merged 3 commits into from
May 1, 2024
Merged

release-23.2: cli: include cpu profiles into debug.zip #123243

merged 3 commits into from
May 1, 2024

Commits on Apr 29, 2024

  1. cli: remove some code duplication when retrieving file lists 

    We have effectively the same code copy-pasted for retrieving lists of
heap profiles and goroutine dumps. This commit extracts the helper to
avoid the duplication to facilitate introducing the collection of cpu
profiles too. This is effectively a no-op change.

Release note: None
    @yuzefovich
    yuzefovich committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e831a9b View commit details
    Browse the repository at this point in the history

  2. cli: clean up just added helper a bit 

    Also add some log scopes to the tests.

Release note: None
    @yuzefovich
    yuzefovich committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    fede5cc View commit details
    Browse the repository at this point in the history

  3. cli: include cpu profiles into debug.zip 

    This commit extends `GetFiles` API to support sending CPU profiles
(collected by the CPU profiler) and uses this in the debug.zip to
automatically include all relevant CPU profiles (this is in addition to
collecting fresh CPU profiles at the time debug.zip is taken). In 24.1
time frame we enabled the CPU profiler by default, so this is a nice
addition to that. (Note that on CC clusters we had the CPU profiler
enabled already, and SREs had to manually fetch the CPU profiles since
it wasn't included into the debug.zip. This will remove that extra
overhead.)

Release note: None
    @yuzefovich
    yuzefovich committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    31641fc View commit details
    Browse the repository at this point in the history