New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: cli: include cpu profiles into debug.zip #123243
Merged
yuzefovich
merged 3 commits into
release-23.2
from
blathers/backport-release-23.2-123172
May 1, 2024
Merged
release-23.2: cli: include cpu profiles into debug.zip #123243
yuzefovich
merged 3 commits into
release-23.2
from
blathers/backport-release-23.2-123172
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.2-123172
branch
from
April 29, 2024 19:22
9bd758e
to
5f3eb17
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Apr 29, 2024
blathers-crl
bot
requested review from
DarrylWong and
renatolabs
and removed request for
a team
April 29, 2024 19:22
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Apr 29, 2024
yuzefovich
requested review from
dhartunian
and removed request for
a team,
DarrylWong,
renatolabs and
xinhaoz
April 29, 2024 19:23
We have effectively the same code copy-pasted for retrieving lists of heap profiles and goroutine dumps. This commit extracts the helper to avoid the duplication to facilitate introducing the collection of cpu profiles too. This is effectively a no-op change. Release note: None
Also add some log scopes to the tests. Release note: None
This commit extends `GetFiles` API to support sending CPU profiles (collected by the CPU profiler) and uses this in the debug.zip to automatically include all relevant CPU profiles (this is in addition to collecting fresh CPU profiles at the time debug.zip is taken). In 24.1 time frame we enabled the CPU profiler by default, so this is a nice addition to that. (Note that on CC clusters we had the CPU profiler enabled already, and SREs had to manually fetch the CPU profiles since it wasn't included into the debug.zip. This will remove that extra overhead.) Release note: None
yuzefovich
force-pushed
the
blathers/backport-release-23.2-123172
branch
from
April 29, 2024 20:07
5f3eb17
to
31641fc
Compare
Just squashed #123248 into the first commit. |
dhartunian
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3/3 commits from #123172 on behalf of @yuzefovich.
/cc @cockroachdb/release
This commit extends
GetFiles
API to support sending CPU profiles (collected by the CPU profiler) and uses this in the debug.zip to automatically include all relevant CPU profiles (this is in addition to collecting fresh CPU profiles at the time debug.zip is taken). In 24.1 time frame we enabled the CPU profiler by default, so this is a nice addition to that. (Note that on CC clusters we had the CPU profiler enabled already, and SREs had to manually fetch the CPU profiles since it wasn't included into the debug.zip. This will remove that extra overhead.)Fixes: #105012.
Release note: None
Release justification: low-risk improvement.