Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: cli: include cpu profiles into debug.zip #123243

Merged
merged 3 commits into from May 1, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 29, 2024

Backport 3/3 commits from #123172 on behalf of @yuzefovich.

/cc @cockroachdb/release


This commit extends GetFiles API to support sending CPU profiles (collected by the CPU profiler) and uses this in the debug.zip to automatically include all relevant CPU profiles (this is in addition to collecting fresh CPU profiles at the time debug.zip is taken). In 24.1 time frame we enabled the CPU profiler by default, so this is a nice addition to that. (Note that on CC clusters we had the CPU profiler enabled already, and SREs had to manually fetch the CPU profiles since it wasn't included into the debug.zip. This will remove that extra overhead.)

Fixes: #105012.

Release note: None


Release justification: low-risk improvement.

@blathers-crl blathers-crl bot requested review from a team as code owners April 29, 2024 19:22
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-123172 branch from 9bd758e to 5f3eb17 Compare April 29, 2024 19:22
@blathers-crl blathers-crl bot requested review from a team as code owners April 29, 2024 19:22
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 29, 2024
@blathers-crl blathers-crl bot requested review from DarrylWong and renatolabs and removed request for a team April 29, 2024 19:22
@blathers-crl blathers-crl bot requested review from xinhaoz and removed request for a team April 29, 2024 19:22
Copy link
Author

blathers-crl bot commented Apr 29, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 29, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich requested review from dhartunian and removed request for a team, DarrylWong, renatolabs and xinhaoz April 29, 2024 19:23
We have effectively the same code copy-pasted for retrieving lists of
heap profiles and goroutine dumps. This commit extracts the helper to
avoid the duplication to facilitate introducing the collection of cpu
profiles too. This is effectively a no-op change.

Release note: None
Also add some log scopes to the tests.

Release note: None
This commit extends `GetFiles` API to support sending CPU profiles
(collected by the CPU profiler) and uses this in the debug.zip to
automatically include all relevant CPU profiles (this is in addition to
collecting fresh CPU profiles at the time debug.zip is taken). In 24.1
time frame we enabled the CPU profiler by default, so this is a nice
addition to that. (Note that on CC clusters we had the CPU profiler
enabled already, and SREs had to manually fetch the CPU profiles since
it wasn't included into the debug.zip. This will remove that extra
overhead.)

Release note: None
@yuzefovich yuzefovich force-pushed the blathers/backport-release-23.2-123172 branch from 5f3eb17 to 31641fc Compare April 29, 2024 20:07
@yuzefovich
Copy link
Member

Just squashed #123248 into the first commit.

@yuzefovich yuzefovich merged commit 44ead6a into release-23.2 May 1, 2024
5 of 6 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-23.2-123172 branch May 1, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants