Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: kvcoord: disable DistSender circuit breakers by default #123211

Merged
merged 2 commits into from
May 1, 2024

Commits on Apr 26, 2024

  1. kvcoord: introduce a new setting to toggle DistSender circuit breakers

    This patch introduces a new cluster setting, called
    `kv.dist_sender.circuit_breakers.mode`, which may be used to configure
    the behaviour of DistSender circuit breakers. This subsumes the previous
    cluster setting, `kv.dist_sender.circuit_breaker.enabled`, which is now
    removed.
    
    The new enum cluster setting comes in 3 variants:
    
    - No ranges: circuit breakers disabled.
    - Node liveness only: circuit breakers are only enabled for replicas
    belonging to the liveness range.
    - All ranges: circuit breakers are enabled for replicas belonging to
    all ranges.
    
    Currently, when configured to node liveness only mode, the setting is
    a lie -- it behaves as if circuit breakers are off. We'll change this
    in the future, underneath the cluster setting.
    
    Informs #123117
    
    Release note: None
    arulajmani committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    749cc5a View commit details
    Browse the repository at this point in the history
  2. kvcoord: disable DistSender circuit breakers by default

    Closes #122983
    
    Release note: None
    arulajmani committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    62761a4 View commit details
    Browse the repository at this point in the history