New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: kvcoord: disable DistSender circuit breakers by default #123211
Merged
arulajmani
merged 2 commits into
release-24.1
from
blathers/backport-release-24.1-123118
May 1, 2024
Merged
release-24.1: kvcoord: disable DistSender circuit breakers by default #123211
arulajmani
merged 2 commits into
release-24.1
from
blathers/backport-release-24.1-123118
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces a new cluster setting, called `kv.dist_sender.circuit_breakers.mode`, which may be used to configure the behaviour of DistSender circuit breakers. This subsumes the previous cluster setting, `kv.dist_sender.circuit_breaker.enabled`, which is now removed. The new enum cluster setting comes in 3 variants: - No ranges: circuit breakers disabled. - Node liveness only: circuit breakers are only enabled for replicas belonging to the liveness range. - All ranges: circuit breakers are enabled for replicas belonging to all ranges. Currently, when configured to node liveness only mode, the setting is a lie -- it behaves as if circuit breakers are off. We'll change this in the future, underneath the cluster setting. Informs #123117 Release note: None
Closes #122983 Release note: None
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Apr 29, 2024
blathers-crl
bot
force-pushed
the
blathers/backport-release-24.1-123118
branch
from
April 29, 2024 15:00
b173808
to
62761a4
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Apr 29, 2024
andrewbaptist
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arulajmani
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #123118 on behalf of @arulajmani.
/cc @cockroachdb/release
See individual commits for details.
Release justification: resolves GA blocker.