Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: remove docker tag from pkg/testutils/docker #123265

Closed
rickystewart opened this issue Apr 29, 2024 · 1 comment · Fixed by #123318
Closed

bazel: remove docker tag from pkg/testutils/docker #123265

rickystewart opened this issue Apr 29, 2024 · 1 comment · Fixed by #123318
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

rickystewart commented Apr 29, 2024 •
edited by cockroach-jira-scripts

The extra tag makes it impossible to reuse pre-built artifacts when you're building this thing. If we want to guard the test from being run on go test ./..., we can simply use an environment variable or some such.

Epic: CRDB-17171

Jira issue: CRDB-38263
@rickystewart rickystewart added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-build-system T-dev-inf labels Apr 29, 2024
@rickystewart
Copy link
Collaborator Author

See also #123319

@rickystewart rickystewart mentioned this issue Apr 30, 2024
Merged
craig bot pushed a commit that referenced this issue May 1, 2024
@rickystewart
Merge #123318
d2dca05 
123318: testutils/docker: remove use of `docker` `gotag` r=rail a=rickystewart

The `docker` tag here doesn't seem to serve any purpose besides preventing the test from being run by `go test ./...`. Instead, we simply skip the test if it's not built with Bazel.

Closes #123265.

Epic: None
Release note: None

Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
@craig craig bot closed this as completed in 8c51559 May 1, 2024
blathers-crl bot pushed a commit that referenced this issue May 1, 2024
@rickystewart
testutils/docker: remove use of docker gotag
0e3db76 
The `docker` tag here doesn't seem to serve any purpose besides
preventing the test from being run by `go test ./...`. Instead, we
simply skip the test if it's not built with Bazel.

Closes #123265.

Epic: None
Release note: None
@blathers-crl blathers-crl bot mentioned this issue May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

testutils/docker: remove use of docker gotag rickystewart/cockroach
1 participant
@rickystewart